Fix failing test on PHP 7.4 with code coverage when skipping some tests#164
Merged
WyriHaximus merged 2 commits intoreactphp:masterfrom Jul 22, 2020
Merged
Fix failing test on PHP 7.4 with code coverage when skipping some tests#164WyriHaximus merged 2 commits intoreactphp:masterfrom
WyriHaximus merged 2 commits intoreactphp:masterfrom
Conversation
This only reports an error on PHP 7.4 when executed like this: $ vendor/bin/phpunit --coverage-text --exclude-group internet
clue
added a commit
to clue-labs/reactphp
that referenced
this pull request
Jul 10, 2020
The build error on PHP 7.4 will be addressed via reactphp/dns#164. Interestingly, it fails in the `FunctionalResolverTest` class and does not fail anymore by excluding any other test file, e.g. `CoopExecutorTest`. It can only be reproduced by running: ``` $ vendor/bin/phpunit --coverage-text --exclude-group internet ``` It can not be reproduced when running on any other PHP version, when `ext-xdebug` is disabled, when coverage is not collected or when not excluding this group. This means the test failure is bogus. We work around this by temporarily skipping one test case for now.
clue
added a commit
to clue-labs/reactphp
that referenced
this pull request
Jul 10, 2020
The build error on PHP 7.4 will be addressed via reactphp/dns#164. Interestingly, it fails in the `FunctionalResolverTest` class and does not fail anymore by excluding some other test cases. It can only be reproduced by running: ``` $ vendor/bin/phpunit --coverage-text --exclude-group internet ``` It can not be reproduced when running on any other PHP version, when `ext-xdebug` is disabled, when coverage is not collected or when not excluding this group. This means the test failure is bogus. We work around this by temporarily skipping some test case for now.
jsor
approved these changes
Jul 11, 2020
WyriHaximus
approved these changes
Jul 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only reports an error on PHP 7.4 when executed like this:
This has been worked around by clearing garbage twice (see #156). Interestingly, this does not actually affect any of the excluded tests but only seems to show up at a later stage.
Builds on top of #156